Derby
  1. Derby
  2. DERBY-1583

With grant revoke enabled, defining a trigger whose actions updates a table (from different schema) results in NPE

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.2.1.6
    • Fix Version/s: 10.2.2.0, 10.3.1.4
    • Component/s: SQL
    • Labels:
      None
    • Urgency:
      Urgent

      Description

      While working on SQL authorization work, I ran across a test case where Derby will throw a NPE when a trigger is defined with it's action as update a table from another schema. I don't have much details on why but following is the test case. Derby is trying to put privilege requirement for a column into privilege requirements list and it expects the column's tableUUID to be not null but in this particular case, it is null.

      connect 'jdbc:derby:c:/dellater/dbmain;create=true' user 'mamta1' as mamta1;
      create table t11TriggerRevokeTest (c111 int not null primary key, c12 int);
      grant TRIGGER on t11TriggerRevokeTest to mamta2;
      create table t12TriggerRevokeTest (c121 int, c122 int, c123 int);
      grant UPDATE(c122, c121) on t12TriggerRevokeTest to mamta2;
      connect 'jdbc:derby:c:/dellater/dbmain;create=true' user 'mamta2' as mamta2;
      create trigger tr11t11 after insert on mamta1.t11TriggerRevokeTest for each statement mode db2sql
      update mamta1.t12TriggerRevokeTest set c122 = 99;

      The stack trace looks as follows
      ij(MAMTA2)> ERROR XJ001: Java exception: ': java.lang.NullPointerException'.java.lang.NullPointerException
      at org.apache.derby.impl.sql.compile.CompilerContextImpl.addRequiredColumnPriv(CompilerContextImpl.java:741)
      at org.apache.derby.impl.sql.compile.ResultColumn.bindResultColumnByName(ResultColumn.java:682)
      at org.apache.derby.impl.sql.compile.ResultColumnList.bindResultColumnsByName(ResultColumnList.java:635)
      at org.apache.derby.impl.sql.compile.ResultSetNode.bindResultColumns(ResultSetNode.java:682)
      at org.apache.derby.impl.sql.compile.SelectNode.bindResultColumns(SelectNode.java:751)
      at org.apache.derby.impl.sql.compile.UpdateNode.bind(UpdateNode.java:348)
      at org.apache.derby.impl.sql.GenericStatement.prepMinion(GenericStatement.java:344)
      at org.apache.derby.impl.sql.GenericStatement.prepareStorable(GenericStatement.java:591)
      at org.apache.derby.iapi.sql.dictionary.SPSDescriptor.compileStatement(SPSDescriptor.java:353)
      at org.apache.derby.iapi.sql.dictionary.SPSDescriptor.prepareAndRelease(SPSDescriptor.java:283)
      at org.apache.derby.impl.sql.execute.CreateTriggerConstantAction.createSPS(CreateTriggerConstantAction.java:367)
      at org.apache.derby.impl.sql.execute.CreateTriggerConstantAction.executeConstantAction(CreateTriggerConstantAction.java:272)
      at org.apache.derby.impl.sql.execute.MiscResultSet.open(MiscResultSet.java:56)
      at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:357)
      at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1181)
      at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:584)
      at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:516)
      at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:313)
      at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:433)
      at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:310)
      at org.apache.derby.impl.tools.ij.Main.go(Main.java:207)
      at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:173)
      at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:55)
      at org.apache.derby.tools.ij.main(ij.java:60)

      1. setTableDescriptor.diff
        0.3 kB
        Bryan Pendleton
      2. setTableDescriptor.diff
        3 kB
        Bryan Pendleton
      3. skipAddPriv.diff
        3 kB
        Bryan Pendleton
      4. skipAddPriv_v2.diff
        8 kB
        Bryan Pendleton
      5. skipAddPriv_v3.diff
        9 kB
        Bryan Pendleton

        Issue Links

          Activity

          Gavin made changes -
          Workflow jira [ 12376749 ] Default workflow, editable Closed status [ 12801429 ]
          Andrew McIntyre made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Bryan Pendleton made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 10.2.1.0 [ 11187 ]
          Derby Info [Patch Available]
          Fix Version/s 10.2.2.0 [ 12312027 ]
          Mike Matrigali made changes -
          Fix Version/s 10.3.0.0 [ 12310800 ]
          Bryan Pendleton made changes -
          Attachment skipAddPriv_v3.diff [ 12339808 ]
          Bryan Pendleton made changes -
          Derby Info [Patch Available]
          Bryan Pendleton made changes -
          Attachment skipAddPriv_v2.diff [ 12339803 ]
          Bryan Pendleton made changes -
          Derby Info [Patch Available]
          Bryan Pendleton made changes -
          Attachment skipAddPriv.diff [ 12339741 ]
          Bryan Pendleton made changes -
          Link This issue relates to DERBY-1724 [ DERBY-1724 ]
          Bryan Pendleton made changes -
          Attachment setTableDescriptor.diff [ 12339650 ]
          Bryan Pendleton made changes -
          Derby Info [Patch Available]
          Assignee Bryan Pendleton [ bryanpendleton ]
          Bryan Pendleton made changes -
          Attachment setTableDescriptor.diff [ 12339646 ]
          Bryan Pendleton made changes -
          Link This issue is duplicated by DERBY-1754 [ DERBY-1754 ]
          Bryan Pendleton made changes -
          Link This issue blocks DERBY-1489 [ DERBY-1489 ]
          Rick Hillegas made changes -
          Urgency Normal Urgent
          Yip Ng made changes -
          Link This issue is related to DERBY-464 [ DERBY-464 ]
          Rick Hillegas made changes -
          Field Original Value New Value
          Urgency Normal
          Mamta A. Satoor created issue -

            People

            • Assignee:
              Bryan Pendleton
              Reporter:
              Mamta A. Satoor
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development