Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-1347

derbynet/SuicideOfStreaming.java should not use internal class SqlCode

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Test
    • Labels:
      None

      Description

      In the method examineExpectedInDerbyNetClient, the code validates the error code using the following:

      return
      sqlex.getSQLState().equals("08006") &&
      sqlex.getErrorCode() == SqlCode.disconnectError.getCode();

      SqlCode is an internal class and our tests shouldn't rely on it. We should probably just use the error code explicitly, or define a testing class that contains some of the error codes that Derby returns.

      Also: are our error codes even a documented public interface?

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                davidvc David Van Couvering
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: