[DERBY-1347] derbynet/SuicideOfStreaming.java should not use internal class SqlCode

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Duplicate
• Component/s: Test
• Assignee: Unassigned
• Reporter: David Van Couvering
• Created: 26/May/06 00:59
• Updated: 10/Mar/10 11:24
• Resolved: 10/Mar/10 11:24

Description

In the method examineExpectedInDerbyNetClient, the code validates the error code using the following:

return
sqlex.getSQLState().equals("08006") &&
sqlex.getErrorCode() == SqlCode.disconnectError.getCode();

SqlCode is an internal class and our tests shouldn't rely on it. We should probably just use the error code explicitly, or define a testing class that contains some of the error codes that Derby returns.

Also: are our error codes even a documented public interface?

Issue Links

• duplicates: DERBY-2054 Rewrite 'derbynet/SuicideOfStreaming' to a JUnit test