Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-1040

Run store locking tests with network server and investigate locking behaviour

Details

    • Normal

    Description

      The store locking tests should be run with network server, locking behaviour investigated, and a perhaps a proposal made for testing locking with network server. For network server, the pre-fetching of data causes diffs in the tests and I am not sure if this is expected or not. I noticed for example such diffs in updatelocks.sql and readlocks.sql.

      Below is the list of locking tests I see in store. Feel free to take one or two and file a subtask.

      EscalateLock.sql
      RowLockBasic.sql
      RowLockIso.sql
      TableLockBasic.sql
      TableLockBasic.subsql
      lockTableVti.sql
      readBtreeCursorLocks.subsql
      readBtreeSetLocks.subsql
      readCursorLocks.subsql
      readSetLocks.subsql
      readlocks.sql
      updateBtreeCursorLocks.subsql
      updateBtreeHoldCursorLocksJDBC30.subsql
      updateBtreeSetLocks.subsql
      updatecursorlocks.subsql
      updateholdcursorlocksJDBC30.subsql
      updatelocks.sql
      updatelocksJDBC30.sql
      updatesetlocks.subsql
      RowLockIso.sql
      rlliso1multi.sql
      rlliso1multi.subsql
      rlliso2multi.sql
      rlliso3multi.sql

      Attachments

        1. DERBY-1040_LockTableVtiTest.diff
          2 kB
          Myrna van Lunteren

        Issue Links

          Activity

            Turning this from subtask into independent issue, I think that'll be more useful.
            The ultimate goal will be for the tests to get converted to junit and run with network server/client and that any bugs should get logged.
            Also note that differences between embedded and network server/client can get linked to DERBY-310.

            myrna Myrna van Lunteren added a comment - Turning this from subtask into independent issue, I think that'll be more useful. The ultimate goal will be for the tests to get converted to junit and run with network server/client and that any bugs should get logged. Also note that differences between embedded and network server/client can get linked to DERBY-310 .

            I ran all of the remaining tests from derbyall with -Dframework=DerbyNetClient for DERBY-1342, so also the store tests.

            myrna Myrna van Lunteren added a comment - I ran all of the remaining tests from derbyall with -Dframework=DerbyNetClient for DERBY-1342 , so also the store tests.

            the updatelocks.sql test (with subsql files updatesetlocks.subsql, updatelocks.sql, updatesetlocks.subsql) was converted to junit with DERBY-5305. I merged the updatelocksJDBC30.sql (with *JDBC30.subsql) into the converted UpdateLocksTest and then switched the suite to run defaultSuite rather than embeddedSuite for DERBY-6247.
            RowLockBasic.sql was converted to RowLockBasicTest for DERBY-5147 and runs with defaultSuite.
            TableLockBasic.sql was converted to TableLockBasicTest for DERBY-5301 and runs with defaultSuite.

            myrna Myrna van Lunteren added a comment - the updatelocks.sql test (with subsql files updatesetlocks.subsql, updatelocks.sql, updatesetlocks.subsql) was converted to junit with DERBY-5305 . I merged the updatelocksJDBC30.sql (with *JDBC30.subsql) into the converted UpdateLocksTest and then switched the suite to run defaultSuite rather than embeddedSuite for DERBY-6247 . RowLockBasic.sql was converted to RowLockBasicTest for DERBY-5147 and runs with defaultSuite. TableLockBasic.sql was converted to TableLockBasicTest for DERBY-5301 and runs with defaultSuite.

            Attaching a patch which will make the LockTableVtiTest run with defaultSuite (i.e. embedded and client/server).
            Moves the contents of decorateSQL to the setUp method.
            I'll commit this soon.

            myrna Myrna van Lunteren added a comment - Attaching a patch which will make the LockTableVtiTest run with defaultSuite (i.e. embedded and client/server). Moves the contents of decorateSQL to the setUp method. I'll commit this soon.

            Note that a number of the remaining .sql files listed here are currently run through StoreScriptsTest.

            myrna Myrna van Lunteren added a comment - Note that a number of the remaining .sql files listed here are currently run through StoreScriptsTest.

            Commit 1629764 from myrna in branch 'code/trunk'
            [ https://svn.apache.org/r1629764 ]

            DERBY-1040; Run store locking tests with network server and investigate locking behaviour
            Pushing LockTableVtiTest to run with both embedded and DerbyNetClient/Network Server

            jira-bot ASF subversion and git services added a comment - Commit 1629764 from myrna in branch 'code/trunk' [ https://svn.apache.org/r1629764 ] DERBY-1040 ; Run store locking tests with network server and investigate locking behaviour Pushing LockTableVtiTest to run with both embedded and DerbyNetClient/Network Server

            People

              Unassigned Unassigned
              kmarsden Katherine Marsden
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: