[DELTASPIKE-984] DynamicMBeanWrapper throws misleading MBeanException saying that the required action does not exist when MBean method (deliberately) throws an exception

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.2
• Fix Version/s: 1.5.1
• Component/s: Core
• Assignee: Unassigned
• Reporter: Falko Modler
• Created: 01/Sep/15 12:21
• Updated: 27/Oct/15 16:38
• Resolved: 03/Sep/15 17:18

Description

See org.apache.deltaspike.core.impl.jmx.DynamicMBeanWrapper.invoke(String, Object[], String[]):

        if (operations.containsKey(actionName))
        {
            final ClassLoader oldCl = Thread.currentThread().getContextClassLoader();
            Thread.currentThread().setContextClassLoader(classloader);
            try
            {
                return operations.get(actionName).invoke(instance(), params);
            }
            catch (IllegalArgumentException e)
            {
                LOGGER.log(Level.SEVERE, actionName + "can't be invoked", e);
            }
            catch (IllegalAccessException e)
            {
                LOGGER.log(Level.SEVERE, actionName + "can't be invoked", e);
            }
            catch (InvocationTargetException e)
            {
                LOGGER.log(Level.SEVERE, actionName + "can't be invoked", e);
            }
            finally
            {
                Thread.currentThread().setContextClassLoader(oldCl);
            }
        }
        throw new MBeanException(new IllegalArgumentException(), actionName + " doesn't exist");

When the MBean method throws an exception, the wrapper catches and logs the InvocationTargetException. But as the last step a MBeanException with cause actionName + " doesn't exist" is thrown, regardless of what went wrong actually!

The "doesn't exist" exception should be moved into an else block.
The specificly caught exception should be wrapped into a new MBeanException which should be thrown afterwards. If wrapping is not possible due to classloadings constraints, at least the message of the original exception should be retained.