Uploaded image for project: 'DeltaSpike'
  1. DeltaSpike
  2. DELTASPIKE-893

Remove erroneous WarpTest annotation and Warp dependency from JSF impl tests

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.3.0
    • 1.4.0
    • Tests
    • None

    Description

      Many tests in the JSF impl module are annotated @WarpTest and the modules/jsf/impl/pom.xml contains arquillian-warp-api dependency.

      Tests annotated WarpTest:
      https://github.com/apache/deltaspike/search?utf8=%E2%9C%93&q=WarpTest&type=Code

      However, the Warp API doesn't seem to be used at all.
      Therefore, the dependency and annotation on tests (and import) should most likely be removed.

      For reference, see https://github.com/arquillian/arquillian-extension-warp on how Warp API is used and for what purpose. It is used for making server-side assertions in client-side tests.

      Attachments

        Activity

          People

            rafabene Rafael Benevides
            rsmeral Ron Smeral
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: