[DELTASPIKE-831] NPE in DefaultMockFilter when running JUnit and the application contains a class in the default package

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.1
• Fix Version/s: 1.3.0
• Component/s: TestControl
• Environment: JUnit+Deltaspike+OpenEJB 4.6.0 on Windows 7, Oracle JDK 7
• Assignee: Gerhard Petracek
• Reporter: Tobias Rettstadt
• Created: 05/Feb/15 10:04
• Updated: 08/Mar/15 19:56
• Resolved: 06/Feb/15 12:26

Description

Running a unit test results in a NPE if the application contains a class in the default package. The problem is line 67 of org.apache.deltaspike.testcontrol.impl.mock.DefaultMockFilter where
isInternalPackage(origin.getPackage().getName()) is called without checking if getPackage() returns null.

Suggested fix: Change line 67 to

        return origin != null && (origin.getPackage() == null || !isInternalPackage(origin.getPackage().getName()));