[DELTASPIKE-738] ViewConfigTest relies on ordering of elements in a HashSet

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.3
• Fix Version/s: 1.1.0
• Environment: java version "1.8.0_20"; Java(TM) SE Runtime Environment (build 1.8.0_20-b26); Java HotSpot(TM) 64-Bit Server VM (build 25.20-b23, mixed mode)
• Assignee: Gerhard Petracek
• Reporter: Jozef Hartinger
• Created: 06/Oct/14 08:58
• Updated: 04/Nov/14 21:15
• Resolved: 06/Oct/14 09:43

Description

I am observing the following two test failures when running DS agains Weld 2.2.5.Final and 3.0.0.Alpha1 on JDK 8

testCallbackExecutionFolder(org.apache.deltaspike.test.jsf.impl.config.view.controller.uc005.ViewConfigTest): expected:<[param]1> but was:<[org.apache.deltaspike.test.jsf.impl.config.view.controller.uc005.SimpleTestAccessDecisionVoter]1>
testCallbackExecutionPage(org.apache.deltaspike.test.jsf.impl.config.view.controller.uc005.ViewConfigTest): expected:<[param1]> but was:<[org.apache.deltaspike.test.jsf.impl.config.view.controller.uc005.SimpleTestAccessDecisionVoter2]>

Looks like ViewConfigTest checks for order of the elements:
https://github.com/apache/deltaspike/blob/master/deltaspike/modules/jsf/impl/src/test/java/org/apache/deltaspike/test/jsf/impl/config/view/controller/uc005/ViewConfigTest.java#L214

The elements are however placed in a HashSet which does not guarantee order:

https://github.com/apache/deltaspike/blob/master/deltaspike/modules/jsf/impl/src/test/java/org/apache/deltaspike/test/jsf/impl/config/view/controller/uc005/SimpleTestAccessDecisionVoter1.java#L29