Uploaded image for project: 'DeltaSpike'
  1. DeltaSpike
  2. DELTASPIKE-638

re-visit inconsistent handling of @BeforeHandles

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.0.0
    • 1.0.1
    • None

    Description

      #throwOriginal in a @BeforeHandles method leads to #isHandled true, once there is a @Handles method for the same exception. however, in the end the exception gets thrown.

      reason:
      the 2nd instance of DefaultExceptionEvent (for @Handles methods) in ExceptionHandlerBroadcaster, uses the information from ExceptionToCatchEvent.

      that also leads to the situation that every change done by a @BeforeHandles method isn't visible in a @Handles method.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            lightguard Jason Porter
            gpetracek Gerhard Petracek
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment