[DELTASPIKE-555] Do not use package-private methods in CDI beans

• Type: Wish
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.6
• Fix Version/s: 0.7
• Assignee: Gerhard Petracek
• Reporter: Moritz Bechler
• Created: 01/Apr/14 12:53
• Updated: 04/May/14 07:02
• Resolved: 04/Apr/14 07:05

Description

The usage of package private methods for CDI beans leads to the situation that proxies for this bean must be definied in the same classloader that loads the bean class.
In certain environments (where lifetime of classloaders defining CDI beans >> lifecycle of the CDI context) causes really bad memory leaks (a longer discussion of the general problem can be found here: https://issues.apache.org/jira/browse/OWB-931). Mitigation is only possible if the proper classloader is chosen - but this breaks if there are package-private methods to be proxied.
Therefor I would suggest to completely refrain from defining package private methods.

So far I have only found
org.apache.deltaspike.jsf.impl.injection.AbstractBeanStorage.add()
to be such a method.