[DELTASPIKE-225] simplify fluent Message API

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.3-incubating
• Fix Version/s: 0.3-incubating
• Component/s: I18n-Module
• Assignee: Mark Struberg
• Reporter: Mark Struberg
• Created: 06/Jul/12 23:34
• Updated: 24/Aug/12 18:54
• Resolved: 08/Jul/12 11:36

Description

We currently have a pretty complex fluent API for our message stuff. Imo a bit too fluent. The main focus is on always creating immutable objects, but this causes quite some overhead. In fact, the MessageContext itself is always being created as @Dependent scoped bean, thus chances to modify a MessageContext in concurrent manner is not high. Thus we could easily merge MessageContext with MessageContext.Config - we just need to make people aware that they change the MessageContext itself with the fluent API (builder pattern). We can also add a cloneContext() method which will create a new instance based on the current configuration.

The same simplification can be done with MessageBuilder with Message. It doesn't make much sense to distinct between a MessageBuilder#addArguments(...) and Message#addArguments(...). They really do the same.