[DELTASPIKE-1378] EntityManagerRefLookup returns null globalEntityManager when lazyInitGlobalEntityManager is called by multiple threads

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.9.0
• Fix Version/s: 1.9.1
• Component/s: JPA-Module
• Assignee: Thomas Andraschko
• Reporter: Raymond Domingo
• Created: 14/May/19 08:59
• Updated: 19/Aug/19 09:51
• Resolved: 14/May/19 22:38

Description

Situation

If multiple threads invoke lazyInitGlobalEntityManager at same time and lazyInitGlobalEntityManager isn't invoked before. Some of these threads might end up with a null entitymanager, because lazyInitGlobalEntityManager isn't synchronized (or this.globalEntityManagerInitialized = true is at wrong place).

Might be important to fix this, because In rare situations this might break your application and even cause inconsistent data.

Problem

entityManager is null after initialization is concurrently called

Expected

entityManager won't be null when initialized concurrently

 

PR

https://github.com/apache/deltaspike/pull/89

Issue Links

• relates to: DELTASPIKE-1383 Authorizer is marked initialized before being fully initialed. NullPointerException follows.