[DELTASPIKE-1330] Criteria with OR generate AND on query

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Not A Problem
• Affects Version/s: 1.8.1
• Fix Version/s: 1.9.1
• Component/s: Data-Module
• Environment: JDK 8u161, Wildfly 11, JEE 7
• Assignee: Unassigned
• Reporter: Arthur Pereira Gregório
• Created: 21/Mar/18 20:51
• Updated: 18/Dec/18 18:56
• Resolved: 18/Dec/18 18:56

Description

If I use a OR on criteria the generated query use AND instead of OR to mix the properties after WHERE clause.

Sample: 

// code placeholder
default List<T> findAllBy(String filter, Boolean blocked, int start, int pageSize) {

final Criteria<T, T> criteria = criteria();

if (isNotBlank(filter)) {
criteria.or(this.criteria()
.likeIgnoreCase(User_.name, filter)
.likeIgnoreCase(User_.username, filter)
.likeIgnoreCase(User_.email, filter));
} 

if (blocked != null) {
criteria.eq(this.getBlockedProperty(), blocked);
}

criteria.orderDesc(PersistentEntity_.createdOn);

return criteria.createQuery()
.setFirstResult(start)
.setMaxResults(pageSize)
.getResultList();
}

 

Generate this hibernate query: 

17:41:24,813 INFO  [stdout] (default task-64) Hibernate: select user0_.id as id1_4_, user0_.created_by as created_2_4_, user0_.created_on as created_3_4_, user0_.modified_by as modified4_4_, user0_.modified_on as modified5_4_, user0_.blocked as blocked6_4_, user0_.email as email7_4_, user0_.id_group as id_grou12_4_, user0_.name as name8_4_, user0_.password as password9_4_, user0_.store_type as store_t10_4_, user0_.username as usernam11_4_ from security.users user0_ where (upper(user0_.name) like ?) and (upper(user0_.username) like ?) and (upper(user0_.email) like ?) order by user0_.created_on desc limit ?

Issue Links

• links to: GitHub Pull Request #82