[DELTASPIKE-1043] Loop redirect in error-page (404) with CLIENTWINDOW

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.2
• Fix Version/s: 1.5.3
• Component/s: JSF22-Module
• Environment: Error page in web.xml and clientWindowMode and WildFly
• Assignee: Thomas Andraschko
• Reporter: Janario Oliveira
• Created: 18/Dec/15 01:58
• Updated: 08/Feb/16 15:24
• Resolved: 18/Dec/15 15:18

Description

I have defined an error-page in web.xml to 404
<error-page>
<error-code>404</error-code>
<location>/faces/page-not-found.xhtml</location>
</error-page>

But when I use CLIENTWINDOW it starts to redirects in loop from windowhandler.html

As I've seen this happens because the dsrid param is lost after the container forward it to error page. So ClientSideWindowStrategy.getRequestTokenParameter always return null and send to windowhandler.html

Attached a patch to simulate it in jsf-playground
Patch: loop-redirect.patch
After apply it. I ran with: mvn wildfly:run -P run-wildfly-8.0.0
And opened http://localhost:8080/ds/not-found

I've also attached an workaround that put dsrid param as attribute and lookup for it in ClientSideWindowStrategy
I know it isn't the best way but I couldn't find another way to do that