[DDLUTILS-181] If DatabaseTaskBase._simpleLogging is false, _log is never set

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0
• Fix Version/s: 1.1
• Component/s: Ant Tasks
• Assignee: Thomas Dudziak
• Reporter: Joe Fisher
• Created: 20/Jul/07 21:15
• Updated: 08/Mar/08 11:50
• Resolved: 08/Mar/08 11:50

Description

If someone calls setSimpleLogging(false), internal varliaable _log reamins null

As such

DdlToDatabaseTask task = new DdlToDatabaseTask();
task.setSimpleLogging(false);

...
NPE later

Below is my fix (in patch format)

Index: DatabaseTaskBase.java
===================================================================
— DatabaseTaskBase.java (revision 558128)
+++ DatabaseTaskBase.java (working copy)
@@ -345,6 +345,8 @@
{^M
if (_simpleLogging) {^M
initLogging();^M
+ } else {^M
+ _log = LogFactory.getLog(getClass());^M
}^M
^M
if (!hasCommands())^M