Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2
    • Labels:
      None

      Description

      sebb pointed out: "QueryRunner Javadoc says the class is thread-safe. However it has a protected mutable variable DataSource which can also be set/got via public methods. If one thread sets the variable, another may not see the correct value, so the class is not thread-safe."

      We should make the DataSource final and remove the setter.

        Activity

        Dan Fabulich made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 1.2 [ 12312139 ]
        Resolution Fixed [ 1 ]
        Hide
        Dan Fabulich added a comment -

        Fixed in revision 752523.

        Show
        Dan Fabulich added a comment - Fixed in revision 752523.
        Dan Fabulich made changes -
        Field Original Value New Value
        Assignee Dan Fabulich [ dfabulich ]
        Dan Fabulich created issue -

          People

          • Assignee:
            Dan Fabulich
            Reporter:
            Dan Fabulich
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development