[DBUTILS-143] Don't close connection if provided

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6, 1.7
• Fix Version/s: 1.8.0
• Assignee: Carl Franklin Hall
• Reporter: Carl Franklin Hall
• Created: 09/Jan/20 06:01
• Updated: 09/Jan/20 06:29
• Resolved: 09/Jan/20 06:29

Description

Private methods in QueryRunner (e.g. batch, query, insert, update) that are passed a connection rather than creating it should not close that connection.

Since the connection does not originate in those methods, it shouldn't be considered the owner of the connection and therefore shouldn't close it on behalf of the caller.

There are a few convenience methods that create connection using `prepareConnection()`. These should use try-with-resources to handle the connection.