Uploaded image for project: 'Commons DBCP'
  1. Commons DBCP
  2. DBCP-547

Add a ConnectionFactory class name setting for BasicDataSource.createConnectionFactory() #33

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.2.0
    • 2.7.0
    • None

    Description

      It think it would be nice better to implement a ConnectionFactory class name setting in BasicDataSource class or implement a interface in DriverConnectionFactory class.

      In my current project, when getting a connection in my program, I call oracleSetModule.
      so, i think that after creating connection, call oracleSetModule via connectionFactoryImpl seems to be nice.

        

      [Before]

      protected ConnectionFactory createConnectionFactory() throws SQLException

      { ... ... ConnectionFactory driverConnectionFactory = new DriverConnectionFactory(driverToUse, url, connectionProperties); return driverConnectionFactory; }

      [After]

      protected ConnectionFactory createConnectionFactory() throws SQLException

      { ... ... ConnectionFactory driverConnectionFactory = getConnectionFactoryImpl().newInstance(...); return driverConnectionFactory; }

       

      Attachments

        Activity

          People

            Unassigned Unassigned
            Simple Lee Jun Gyun
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2h 10m
                2h 10m