[DBCP-519] Add some toString() methods for debugging (never printing user names and passwords)

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.6.0
• Assignee: Gary D. Gregory
• Reporter: Gary D. Gregory
• Created: 16/Aug/18 18:58
• Updated: 17/Aug/18 19:20
• Resolved: 16/Aug/18 21:04

Description

Add some toString() methods for debugging never printing user names and passwords:

• org.apache.commons.dbcp2.cpdsadapter.DriverAdapterCPDS
• org.apache.commons.dbcp2.cpdsadapter.PooledConnectionImpl
• org.apache.commons.dbcp2.datasources.CPDSConnectionFactory
• org.apache.commons.dbcp2.datasources.InstanceKeyDataSource
• org.apache.commons.dbcp2.datasources.PerUserPoolDataSource
• org.apache.commons.dbcp2.datasources.SharedPoolDataSource
• org.apache.commons.dbcp2.datasources.UserPassKey (updated not to print passwords even though it was a char[] reference.)

I went YAGNI here and only added what I needed.