Uploaded image for project: 'Commons Dbcp'
  1. Commons Dbcp
  2. DBCP-384

PoolingDriver.accessToUnderlyingConnectionAllowed is thread-hostile

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0
    • Labels:
      None

      Description

      The field PoolingDriver.accessToUnderlyingConnectionAllowed is static but mutable; this is inherently thread-hostile.

      It seems completely unnecessary for the field to be static; surely it could be an instance variable?
      Better yet, drop the setter/getter and make the field final, set by the ctor.

        Activity

        Hide
        markt Mark Thomas added a comment -

        API changed so this will only be fixed in 2.0 onwards.

        Show
        markt Mark Thomas added a comment - API changed so this will only be fixed in 2.0 onwards.

          People

          • Assignee:
            Unassigned
            Reporter:
            sebb@apache.org Sebb
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development