[DBCP-384] PoolingDriver.accessToUnderlyingConnectionAllowed is thread-hostile

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0
• Assignee: Unassigned
• Reporter: Sebb
• Created: 26/Apr/12 22:58
• Updated: 31/May/14 04:04
• Resolved: 03/Dec/13 09:36

Description

The field PoolingDriver.accessToUnderlyingConnectionAllowed is static but mutable; this is inherently thread-hostile.

It seems completely unnecessary for the field to be static; surely it could be an instance variable?
Better yet, drop the setter/getter and make the field final, set by the ctor.