Commons Dbcp
  1. Commons Dbcp
  2. DBCP-380

DelegatingConnection isWrapperFor dies on older JDBC drivers

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 1.3.1, 1.4.1, 1.5.1, 2.0
    • Labels:
      None

      Description

      The isWrapperFor function simply calls towards to the delegated connection iswrappedfor function instead of checking the result first by hand like in the unwrap function.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        606d 9h 40m 1 Mark Thomas 09/Dec/13 20:55
        Resolved Resolved Closed Closed
        172d 7h 13m 1 Phil Steitz 31/May/14 04:09
        Phil Steitz made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Mark Thomas made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.3.1 [ 12314492 ]
        Fix Version/s 1.4.1 [ 12314493 ]
        Fix Version/s 1.5.1 [ 12325670 ]
        Fix Version/s 2.0 [ 12313721 ]
        Resolution Fixed [ 1 ]
        Hide
        Mark Thomas added a comment -

        Thanks for the patch. It has been applied to svn and will be included in the next release.

        Show
        Mark Thomas added a comment - Thanks for the patch. It has been applied to svn and will be included in the next release.
        Balazs Zsoldos made changes -
        Affects Version/s 1.4 [ 12312615 ]
        Balazs Zsoldos made changes -
        Field Original Value New Value
        Attachment DelegatingConnection.java.patch [ 12522399 ]
        Hide
        Balazs Zsoldos added a comment -

        With the tiny patch applied the isWrappedFor function will work well even with JDBC drivers that do not implement this function (e.g. Postgres 9.1 or H2)

        Show
        Balazs Zsoldos added a comment - With the tiny patch applied the isWrappedFor function will work well even with JDBC drivers that do not implement this function (e.g. Postgres 9.1 or H2)
        Balazs Zsoldos created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Balazs Zsoldos
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development