[DBCP-372] Statement Leak occurs when batch update is used.

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.3, 1.4
• Fix Version/s: 1.5.1, 2.0

Environment

Oracle 11g

• Assignee: Unassigned
• Reporter: Naozumi Taromaru
• Created: 05/Dec/11 13:10
• Updated: 24/Feb/15 03:23
• Resolved: 03/Feb/14 23:20

Description

org.apache.commons.dbcp.PoolablePreparedStatement#passivate()
execute clearBatch().
(DBCP-264)

But this clearBatch() throw SQLException.
(DelegatingStatement#checkOpen() throw SQLException, because _closed is true.)

The result,
the PoolablePreparedStatement doesn't return to pool, and
the PoolablePreparedStatement doesn't execute PreparedStatement#close().

When a lot of data is processed,
in the case of Oracle

• ORA-00604
• ORA-01000

occurs.

Proposal:
"clearBatch();" in passivate() method
changes as follows.

batchAdded = false;
getInnermostDelegate().clearBatch();

Issue Links

• blocks: DBCP-397 Exception ORA-01000 [Number of open cursors exceeds the limit] is faced when prepared statement pooling is enabled in DBCP 1.3
• is duplicated by: DBCP-397 Exception ORA-01000 [Number of open cursors exceeds the limit] is faced when prepared statement pooling is enabled in DBCP 1.3
• is duplicated by: DBCP-407 PoolablePreparedStatement invalidated because of non cleared batch