Commons Dbcp
  1. Commons Dbcp
  2. DBCP-364

BasicDataSourceFactory#createDataSource return signature should be BasicDataSourceFactory so that caller can invoke methods not declared in DataSource (e.g., close())

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0
    • Labels:
      None

      Description

      BasicDataSourceFactory#createDataSource currently returns a DataSource instance.

      It should a return type of BasicDataSourceFactory. Otherwise the caller has to cast it to invoke close (and other methods specific to the implementation).

        Activity

        Phil Steitz made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Mark Thomas made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Mark Thomas added a comment -

        Thanks for the report and sorry this has taken a while to fix.

        This is an API change so it will be included in 2.0 onwards only.

        Show
        Mark Thomas added a comment - Thanks for the report and sorry this has taken a while to fix. This is an API change so it will be included in 2.0 onwards only.
        Phil Steitz made changes -
        Fix Version/s 2.0 [ 12313721 ]
        ori made changes -
        Field Original Value New Value
        Priority Major [ 3 ] Trivial [ 5 ]
        ori created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            ori
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development