Uploaded image for project: 'Commons DBCP'
  1. Commons DBCP
  2. DBCP-364

BasicDataSourceFactory#createDataSource return signature should be BasicDataSourceFactory so that caller can invoke methods not declared in DataSource (e.g., close())

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0
    • Labels:
      None

      Description

      BasicDataSourceFactory#createDataSource currently returns a DataSource instance.

      It should a return type of BasicDataSourceFactory. Otherwise the caller has to cast it to invoke close (and other methods specific to the implementation).

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              os111 ori
            • Votes:
              1 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: