[DBCP-364] BasicDataSourceFactory#createDataSource return signature should be BasicDataSourceFactory so that caller can invoke methods not declared in DataSource (e.g., close())

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 2.0
• Assignee: Unassigned
• Reporter: ori
• Created: 24/Aug/11 21:21
• Updated: 24/Feb/15 03:23
• Resolved: 03/Feb/14 14:41

Description

BasicDataSourceFactory#createDataSource currently returns a DataSource instance.

It should a return type of BasicDataSourceFactory. Otherwise the caller has to cast it to invoke close (and other methods specific to the implementation).