Commons Dbcp
  1. Commons Dbcp
  2. DBCP-332

Closing BasicDataSource doesn't deregister JDBC driver, causing memory leak

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.3, 1.4
    • Fix Version/s: None
    • Labels:
      None

      Description

      BasicDataSource's method close() doesn't deregister JDBC driver. This causes permgen memory leaks in web server environments, during context reloads. For example, using Tomcat 6.0.26 with Spring, and BasicDataSource declared in Spring context, there is a message printed at web application reload:

      SEVERE: A web application registered the JBDC driver [com.mysql.jdbc.Driver] but failed to unregister it when the web application was stopped. To prevent a memory leak, the JDBC Driver has been forcibly unregistered.

      I was able to fix it by overriding close method this way:

      public class XBasicDataSource extends BasicDataSource {
          @Override
          public synchronized void close() throws SQLException {
              DriverManager.deregisterDriver(DriverManager.getDriver(url));
              super.close();
          }
      }
      

      but I think it should be probably the default behavior of BasicDataSource. Or perhaps there should be some flag/setting on BasicDataSource, named "deregisterDriverAtClose" or so.

        Activity

          People

          • Assignee:
            Unassigned
            Reporter:
            Grzegorz Borkowski
          • Votes:
            20 Vote for this issue
            Watchers:
            22 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development