[DBCP-273] validation on testonborrow does not work

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.1, 1.2.2
• Fix Version/s: 1.3, 1.4
• Assignee: Unassigned
• Reporter: mark lin
• Created: 04/Jul/08 19:44
• Updated: 15/Feb/10 02:33
• Resolved: 25/Jan/09 03:31

Description

Our use of dbcp (1.2.1 and 1.2.2) shows that connection validation on testonborrow does not work. The pool still return closed connections. The error is in the following code. See the commented out line for the specific error.
----------------------
ra = ref.get("testOnBorrow");
if (ra != null && ra.getContent() != null)

{ //comment out old code //ikds.setTestOnBorrow(Boolean.getBoolean(ra.getContent().toString())); ikds.setTestOnBorrow(Boolean.valueOf(ra.getContent().toString()).booleanValue()); }

ra = ref.get("testOnReturn");
if (ra != null && ra.getContent() != null)

{ ikds.setTestOnReturn(Boolean.valueOf( ra.getContent().toString()).booleanValue()); }