Commons Dbcp
  1. Commons Dbcp
  2. DBCP-255

Uninitialized read of parent field in AbandonedTrace

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3
    • Labels:
      None
    • Environment:

      Fortify

      Description

      Seems funky - we pass 'parent' up when constructing AbandonedTrace, but it's just null. Is that right, if it is, let's just put null.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        396d 8h 39m 1 Phil Steitz 16/Feb/09 15:14
        Resolved Resolved Closed Closed
        363d 11h 24m 1 Phil Steitz 15/Feb/10 02:39
        Phil Steitz made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Phil Steitz made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Phil Steitz added a comment -

        Patch applied in r744932

        Show
        Phil Steitz added a comment - Patch applied in r744932
        Phil Steitz made changes -
        Field Original Value New Value
        Attachment AbandonedTracePatch.txt [ 12398690 ]
        Hide
        Phil Steitz added a comment -

        Looks to me like this instance field is superfluous and can be removed. Reads of this field in get/setLastUsed are null-guarded. Unless I am missing something, the instance field will always be null. The attached patch removes the field.

        Show
        Phil Steitz added a comment - Looks to me like this instance field is superfluous and can be removed. Reads of this field in get/setLastUsed are null-guarded. Unless I am missing something, the instance field will always be null. The attached patch removes the field.
        Hide
        Henri Yandell added a comment -

        In fact, parent is never written to; so definitely unhappy.

        I suspect all uses are wrapped in 'if-nulls', so it's never blown up.

        Show
        Henri Yandell added a comment - In fact, parent is never written to; so definitely unhappy. I suspect all uses are wrapped in 'if-nulls', so it's never blown up.
        Henri Yandell created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Henri Yandell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development