[DBCP-193] BasicDataSource returns negative values for NumActive when Oracle Driver Connection#isClosed return true (End of file communication on CHannel)

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.2.1, 1.2.2
• Fix Version/s: 1.3

Environment

Windows / Oracle 10G JDBC driver / Oracle 10G / JDK 1.4.2_08 / Commons-dbcp-1.2.1.jar / COmmons-pool-1.3.jar

• Assignee: Unassigned
• Reporter: Philippe Mouawad
• Created: 13/Jul/06 04:29
• Updated: 25/Mar/08 08:11
• Resolved: 29/Jul/07 15:39

Description

Hello,
This bug occurs if the following conditions are met:
A End of File communication on CHannel occurs
Oracle Driver 10G will return true for Connection#isClosed()

Related bugs:
DBCP-3
DBCP-28

Case 1:
The client calls isClosed() before closing a connection since commons-dbcp does not allow double close without throwing (see DBCP-3)
=> The problem is that since he calls isClosed, he encounters the same bug reported in DBCP-28 because conn.isClosed() will return true and the client will not call close.
if (!conn.isClosed())
{
try{
conn.close();
}catch(Exception e){}
}
see what happens if the isClosed() in PoolableConnection returns true : ShowsLeaksIfCheckForIsClosed.java

Case2:
The client tries to find a solution, and calls conn.close() without checking isClosed(), but the problem is that the client is in a Persistence fwk and the client may have already called close, so he ends up calling close() twice, see what happens if the isClosed() in PoolableConnection returns true : ShowsBasicDataSourceBadNumActiveIfNoCheckForIsClosedAndDoubleClose.java

Issue Links

• depends upon: DBCP-3 [dbcp] PoolableConnection.close() won't allow multiple close