Uploaded image for project: 'Commons DBCP'
  1. Commons DBCP
  2. DBCP-191

[dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.3
    • None

    Description

      Just a heads up, [dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0, even with maven.compile.source and maven.compile.target properties set to something appropriate.

      $ maven java:compile
      __ __

      \/ __ Apache_ ___
        \/ / ` \ V / -) ' \ ~ intelligent projects ~
      _   _,_ _/___ _ _ v. 1.0.2

      java:prepare-filesystem:
      [mkdir] Created dir: working/commons-dbcp/target/classes

      java:compile:
      [echo] Compiling to working/commons-dbcp/target/classes
      [echo]
      ==========================================================

      NOTE: Targetting JVM 1.6, classes
      will not run on earlier JVMs

      ==========================================================

      [javac] Compiling 39 source files to working/commons-dbcp/target/classes
      working/commons-dbcp/src/java/org/apache/commons/dbcp/BasicDataSource.java:43: org.apache.commons.dbcp.BasicDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
      public class BasicDataSource implements DataSource {
      ^
      working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/ConnectionImpl.java: 40: org.apache.commons.dbcp.cpdsadapter.ConnectionImpl is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
      class ConnectionImpl implements Connection {
      ^
      working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/PooledConnectionImpl.java:42: org.apache.commons.dbcp.cpdsadapter.PooledConnectionImpl is not abstract and does not override abstract method removeStatementEventListener(javax.sql.StatementEventListener) in javax.sql.PooledConnection
      class PooledConnectionImpl
      ^
      working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingConnection.java:50: org.apache.commons.dbcp.DelegatingConnection is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
      public class DelegatingConnection extends AbandonedTrace
      ^
      working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/DriverAdapterCPDS.java:85: org.apache.commons.dbcp.cpdsadapter.DriverAdapterCPDS is not abstract and does not override abstract method getQueryObjectGenerator() in javax.sql.CommonDataSource
      public class DriverAdapterCPDS
      ^
      working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingStatement.java:45: org.apache.commons.dbcp.DelegatingStatement is not abstract and does not override abstract method isPoolable() in java.sql.Statement
      public class DelegatingStatement extends AbandonedTrace implements Statement {
      ^
      working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingStatement.java:130: isClosed() in org.apache.commons.dbcp.DelegatingStatement cannot implement isClosed() in java.sql.Statement; attempting to assign weaker access privileges; was public
      protected boolean isClosed() {
      ^
      working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingPreparedStatement.java:49: org.apache.commons.dbcp.DelegatingPreparedStatement is not abstract and does not override abstract method setCharacterStream(int,java.io.Reader,long) in java.sql.PreparedStatement
      public class DelegatingPreparedStatement extends DelegatingStatement
      ^
      working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolablePreparedStatement.java:40: org.apache.commons.dbcp.PoolablePreparedStatement is not abstract and does not override abstract method setCharacterStream(int,java.io.Reader,long) in java.sql.PreparedStatement
      public class PoolablePreparedStatement extends DelegatingPreparedStatement implements PreparedStatement {
      ^
      working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/PoolablePreparedStatementStub.java:33: isClosed() in org.apache.commons.dbcp.DelegatingStatement cannot implement isClosed() in java.sql.Statement; attempting to assign weaker access privileges; was public
      class PoolablePreparedStatementStub extends PoolablePreparedStatement {
      ^
      working/commons-dbcp/src/java/org/apache/commons/dbcp/datasources/PerUserPoolDataSource.java:51: org.apache.commons.dbcp.datasources.PerUserPoolDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
      public class PerUserPoolDataSource
      ^
      working/commons-dbcp/src/java/org/apache/commons/dbcp/datasources/SharedPoolDataSource.java:45: org.apache.commons.dbcp.datasources.SharedPoolDataSource is not abstract and does not override abstract method
      <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
      public class SharedPoolDataSource
      ^
      working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingCallableStatement.java:52: org.apache.commons.dbcp.DelegatingCallableStatement is not abstract and does not override abstract method setCharacterStream(java.lang.String,java.io.Reader,long) in java.sql.CallableStatement
      public class DelegatingCallableStatement extends DelegatingPreparedStatement
      ^
      working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingResultSet.java:54: org.apache.commons.dbcp.DelegatingResultSet is not abstract and does not override abstract method updateNClob(java.lang.String,java.io.Reader,long) in java.sql.ResultSet
      public class DelegatingResultSet extends AbandonedTrace implements ResultSet {
      ^
      working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolingConnection.java:41: org.apache.commons.dbcp.PoolingConnection is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
      public class PoolingConnection extends DelegatingConnection implements Connection, KeyedPoolableObjectFactory {
      ^
      working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolingDataSource.java:44: org.apache.commons.dbcp.PoolingDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
      public class PoolingDataSource implements DataSource {
      ^
      Note: Some input files use or override a deprecated API.
      Note: Recompile with -Xlint:deprecation for details.
      Note: Some input files use unchecked or unsafe operations.
      Note: Recompile with -Xlint:unchecked for details.
      16 errors

      BUILD FAILED
      File...... .maven/cache/maven-java-plugin-1.5/plugin.jelly
      Element... ant:javac
      Line...... 63
      Column.... 48
      Compile failed; see the compiler error output for details.

      Attachments

        1. patch.txt
          63 kB
          Michael Heuer

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            heuermh Michael Heuer
            Votes:
            5 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment