[DAFFODIL-2808] Incorrect Validation Error on Optional Element with Children

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Fix Version/s: 3.5.0
• Component/s: Back End
• Assignee: Steve Lawrence
• Reporter: Olabusayo Kilo
• Created: 14/Apr/23 14:42
• Updated: 18/Apr/23 15:45
• Resolved: 17/Apr/23 15:47

Description

When you have an optional element with children element, daffodil calculates the number of occurrences it has by looking at the number of children it has, rather than calculating the number of times it appears. This results in an validation error saying the element occurred NUM_OF_CHILDREN_TIME when it was expected.

Attached is a TDML test that shows this incorrect validation error

I narrowed down the error to src/main/scala/org/apache/daffodil/runtime1/processors/parsers/SequenceChildBases.scala line 543 in endArray

        val occurrence = {
          val maybeLastChild = state.infoset.maybeLastChild
          if (maybeLastChild.isEmpty || maybeLastChild.get.erd != erd)
            0
          else
            maybeLastChild.get.numChildren
        }