[DAFFODIL-2803] Warnings included in serialized DataProcessor

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.5.0
• Component/s: Diagnostics
• Assignee: Unassigned
• Reporter: Steve Lawrence
• Created: 13/Mar/23 15:40
• Updated: 15/Jun/23 17:01
• Resolved: 02/Jun/23 11:52

Description

When a schema is compiled and serialized, any warnings that were created as part of the compilation are also serialized. Which means a reloaded DataProcessor includes those same warnings that were output during compilation.

DAFFODIL-2267 modified the CLI so that it does not output any diagnostics on a reloaded DataProcessor, but API users could still output those diagnostics which is likely not what they want. Reloaded parsers really show have no diagnostics associated with them.

Note that these reloaded warning diagnostic do not become part of the Parse/UnparseResult diagnostics. So even if API users output warnings on a reloaded DataProcessor, they at least won't see them for every parse.

But to avoid the possibility of these excess warnings, we should modify the save parser function so that it removes all diagnostics from the DataProcessor when saved.