[DAFFODIL-2510] Thread Safety: Improve Logger/Logging

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.2.0
• Component/s: Back End, CLI, Front End, Libraries, Middle "End", TDML Runner
• Assignee: Steve Lawrence
• Reporter: Mike Beckerle
• Created: 27/Apr/21 23:19
• Updated: 20/Aug/21 13:42
• Resolved: 16/Aug/21 11:34

Description

Every object that mixes in the Logging trait gets its own mutable vars for logWriter and logLevel, and if not set, shares a single global state in the LoggingDefaults object.

This is not thread safe. At minimum LoggingDefaults should be a ThreadLocal.

Furthermore, those objects don't need independent ability to specify a unique logger or logging level. They should be sharing a logger supplied by the application.