Uploaded image for project: 'Daffodil'
  1. Daffodil
  2. DAFFODIL-2252

Custom GitHub action to check pull requests with more than one commit

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 3.2.0
    • Infrastructure

    Description

      Often times we add multiple fixup commits to a pull request based on review comments, but forget to squash before merging. This leads to a slightly messier commit history where a single commit doesn't show the full story of what chnaged.

      To avoid this, we should add a custom GithubActions check that determines the number of commits in a pull request and either shows a check failure, or disalllows merging completely.

      Attachments

        Activity

          People

            slawrence Steve Lawrence
            slawrence Steve Lawrence
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: