[DAFFODIL-2226] MS Windows: unnecessarily repetitive conditionalization in CLI/command-line-oriented tests

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 2.4.0
• Component/s: Clean Ups, QA
• Labels: beginner
• Assignee: Unassigned
• Reporter: Mike Beckerle
• Created: 01/Nov/19 00:05
• Updated: 19/Aug/21 10:41
• Resolved: 12/Aug/21 12:52

Description

CLI tests, and tests of some features like UDFs are following a pattern which is unnecessarily redundant:

    val schemaFile = Util.daffodilPath("daffodil-udf/src/test/resources/org/apache/daffodil/udf/genericUdfSchema.xsd")

        val (testSchemaFile) = if (Util.isWindows) (Util.cmdConvert(schemaFile)) else (schemaFile)

Every file path used by every test has this explicit MS-Windows conditionalization in it. Over and over and over.

This should be replaced by things that combine what Util.daffodilPath and Util.cmdConvert do, so that all we require is that people construct a, for example, Util.filePath(....) object from a platform independent (i.e., "/" separated) path name. The fact that this requires MS-windows conditionalization should be hidden.

Issue Links

• is related to: DAFFODIL-2381 Refactor test util to eliminate redundant windows baggage from CLI Tests