[DAFFODIL-1988] textOutputMinLength - incorrect code found by inspection

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.0
• Fix Version/s: 2.3.0
• Component/s: Middle "End"
• Assignee: Dave Thompson
• Reporter: Mike Beckerle
• Created: 16/Aug/18 12:48
• Updated: 20/May/21 12:33
• Resolved: 07/Sep/18 14:36

Description

This logic
{{
val isTypeUsingTextOutputMinLength = typeDef.typeNode match

{ case s: NodeInfo.String.Kind => false case s: NodeInfo.HexBinary.Kind => false case s: NodeInfo.AnySimpleType.Kind if (impliedRepresentation eq Representation.Binary) && this.textOutputMinLength > 0 => true case _ => false }

}}

The sense of the "if (impliedRepresentation eq Representation.Binary) is backward. It should be asking if it is Representation.Text.

This is used to issue an SDE about explicit length being out of range for textOutputMinLength, but will clearly not do so in the right way.