[CXF-8987] Java 21 - HttpClientHTTPConduit thread locked during shutdown

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 4.0.3, 4.0.4
• Fix Version/s: 4.1.0, 4.0.5, 3.6.4
• Component/s: Transports

Environment

thdump2

OpenJDK 21.0.2

Apache CXF 4.0.4

Apache Camel 4.4.1

• Estimated Complexity: Unknown
• Assignee: Andriy Redko
• Reporter: Giacomo Carnevale
• Created: 15/Mar/24 17:47
• Updated: 11/May/24 19:42
• Resolved: 11/May/24 19:42

Description

Hi,

I am using Apache CXF client via the Apache Camel CXF connector.

After I updated frm OpenJDK 17.x to OpenJDK 21.0.2, during application shutdown, the following lock occurs:

at java.lang.Thread.join(java.base@21.0.2/Thread.java:2072)
    - locked <0x000000061cd2ab80> (a jdk.internal.net.http.HttpClientImpl$SelectorManager)
    at java.lang.Thread.join(java.base@21.0.2/Thread.java:2200)
    at jdk.internal.net.http.HttpClientImpl.awaitTermination(java.net.http@21.0.2/HttpClientImpl.java:628)
    at java.net.http.HttpClient.close(java.net.http@21.0.2/HttpClient.java:900)
    at jdk.internal.net.http.HttpClientFacade.close(java.net.http@21.0.2/HttpClientFacade.java:192)
    at org.apache.cxf.transport.http.HttpClientHTTPConduit.close(HttpClientHTTPConduit.java:125)

HttpClientHTTPConduit.close

public void close() {
    if (client instanceof AutoCloseable) {
        try {
            ((AutoCloseable)client).close();
        } catch (Exception e) {
            //ignore
        }
    } else if (client != null) {
        String name = client.toString();
        client = null;
        tryToShutdownSelector(name);
    }
    defaultAddress = null;
    super.close();
} 

 
java.net.HttpClient.close
 

public void close() {
    boolean terminated = isTerminated();
    if (!terminated) {
        shutdown();
        boolean interrupted = false;
        while (!terminated) {
            try {
                terminated = awaitTermination(Duration.ofDays(1L));
            } catch (InterruptedException e) {
                if (!interrupted) {
                    interrupted = true;
                    shutdownNow();
                    if (isTerminated()) break;
                }
            }
        }
        if (interrupted) {
            Thread.currentThread().interrupt();
        }
    }
} 

My workaround

public void close() {
    if (client instanceof AutoCloseable) {
        try {
            client.shutdownNow();
            //((AutoCloseable)client).close();
        } catch (Exception e) {
            //ignore
        }
    } else if (client != null) {
        String name = client.toString();
        client = null;
        tryToShutdownSelector(name);
    }
    defaultAddress = null;
    super.close();
} 

Issue Links

• links to: GitHub Pull Request #1854