[CXF-8908] Correct the SOAP FAULT Error Message in ReadHeadersInterceptor

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Not A Problem
• Affects Version/s: 3.5.3
• Component/s: JAX-WS Runtime, Soap Binding
• Estimated Complexity: Unknown
• Assignee: Unassigned
• Reporter: Sreenivas K
• Created: 28/Jul/23 07:55
• Updated: 18/Sep/23 18:49
• Resolved: 30/Jul/23 22:30

Description

Our clients are invoking SOAP webservices with GET (for healthcheck to know webservice is up or not) and they are failing at ReadHeadersInterceptor with SOAP FAULT error like this:

Payload: <soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/">
  <soap:Body>
    <soap:Fault>
      <faultcode>soap:Server</faultcode>
      <faultstring>HTTP verb was not GET or POST</faultstring>
    </soap:Fault>
  </soap:Body>

 

Throwing error is fine, but message needs correction as per the logic in ReadHeadersInterceptor  where you are checking only for POST:

if (verb != null && !"POST".equals(verb)) {
    Fault formula405 = new Fault("HTTP verb was not GET or POST", LOG);
    formula405.setStatusCode(405);
    throw formula405;
}

Please change error message to HTTP verb was not POST so that it helps clients to understand whats wrong.