[CXF-8712] RetryStrategy tries one time too often

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.7
• Fix Version/s: 3.5.4, 3.4.9, 4.0.0, 3.6.0
• Component/s: Clustering
• Estimated Complexity: Unknown
• Assignee: Unassigned
• Reporter: Konrad Windszus
• Created: 08/Jun/22 07:09
• Updated: 18/Sep/23 18:48
• Resolved: 30/Sep/22 16:19

Description

The maxNumberOfRetries is not correctly evaluated in the RetryStrategy. If it is set to 3, the amount of retries is actually 4.

This is due to the fact that getNextAlternate() will return the same result for both stillTheSameAddress returning either false or true.
Although the break condition in https://github.com/apache/cxf/blob/75fb6bb56d82f72771a9ee6ecab5d36168303f51/rt/features/clustering/src/main/java/org/apache/cxf/clustering/RetryStrategy.java#L55 is correct, the logic in https://github.com/apache/cxf/blob/75fb6bb56d82f72771a9ee6ecab5d36168303f51/rt/features/clustering/src/main/java/org/apache/cxf/clustering/RetryStrategy.java#L45 is flawed, as it will not return the next alternate in case stillTheSameAddress returns false.

Issue Links

• links to: GitHub Pull Request #954