[CXF-8705] Multiple encrypted XML elements fail crypto coverage check

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Cannot Reproduce
• Affects Version/s: 3.5.2
• Component/s: JAX-WS Runtime

Environment

• Apache Maven 3.8.5
• Java version: 11.0.12, vendor: Eclipse Foundation
• Apache Tomcat 9.0.62
• openSUSE Tumbleweed 20220509

• Estimated Complexity: Moderate
• Assignee: Unassigned
• Reporter: David Lakatos
• Created: 18/May/22 09:45
• Updated: 21/Jun/22 06:36
• Resolved: 17/Jun/22 07:04

Description

Hello colleagues,

I probably found a bug in org.apache.cxf.ws.security.wss4j.CryptoCoverageChecker.

• Issue: SOAP XML message encryption coverage checking for more than 1 XML elements does not work. If only 1 XML element encryption coverage is checked, everything works fine.
• Symptoms: CryptoCoverageUtil.matchElement(Collection<WSDataRef>, CoverageScope, Element) compares objects via references (r.getProtectedElement() == el) but they are always different objects
• Reproducer JUnit tests are provided on GitHub: greatit/crypto-coverage-test

Fixing the issue would be much appreciated. Thank you.