[CXF-7765] URITemplate.compareTemplates returns inconsistent results

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1.15
• Fix Version/s: 3.2.6, 3.1.17
• Component/s: JAX-RS
• Estimated Complexity: Unknown
• Assignee: Colm O hEigeartaigh
• Reporter: Shon Vella
• Created: 19/Jun/18 17:13
• Updated: 03/Oct/18 13:33
• Resolved: 26/Jun/18 23:04

Description

When org.apache.cxf.jaxrs.model.URITemplate.compareTemplates() is passed two templates with the same number of literal characters, it returns -1 regardless of the order the templates a passed in. I suppose this may be on purpose, but the result is that if compareTemplates() is used as the basis of a Comparator<URITemplate> that is used by java.util.Collections.sort() it can result in:

java.lang.IllegalArgumentException: Comparison method violates its general contract!

I would also expect that this would result in some degree of unpredictability of the prioritization of when selecting the appropriate JAX-RS method to call for a given request.

Issue Links

• links to: GitHub Pull Request #425