Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
None
-
None
-
Unknown
Description
Currently the trace ids are not propagated and not reflected on log MDC metadata when it is not sampled. Seems that in AbstractBraveProvider.class and AbstractBraveClientProvider.class there is a condition which decides whether or not to do the "brave tracing". I had a chat with adriancole and he suggested me to fix this condition by removing the check on span#isNoop, since it is not the provider responsibility I guess.
I'm going to do a pull request on github.
Attachments
Issue Links
- links to