[CXF-7608] [brave feature] Propagate trace ids as it lets log correlation to be consistent even if not sampling

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.2.2, 3.1.15
• Component/s: Integration
• Estimated Complexity: Unknown
• Assignee: Unassigned
• Reporter: Aldo Sinanaj
• Created: 12/Jan/18 16:10
• Updated: 07/Feb/18 14:52
• Resolved: 19/Jan/18 02:19

Description

Currently the trace ids are not propagated and not reflected on log MDC metadata when it is not sampled. Seems that in AbstractBraveProvider.class and AbstractBraveClientProvider.class there is a condition which decides whether or not to do the "brave tracing". I had a chat with adriancole and he suggested me to fix this condition by removing the check on span#isNoop, since it is not the provider responsibility I guess.
I'm going to do a pull request on github.

Issue Links

• links to: GitHub Pull Request #367