Uploaded image for project: 'CXF'
  1. CXF
  2. CXF-7471

WSRM - Use createResendCandidate() instead of constructor directly

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.12
    • Fix Version/s: 3.1.15, 3.2.3, 3.2.4
    • Component/s: WS-* Components
    • Labels:
      None
    • Estimated Complexity:
      Novice

      Description

      In the RetransmissionQueueImpl, cacheUnacknowledged() method, line 350, the resend candidate is created with constructor directly:
      candidate = new ResendCandidate(message);
      I see there is a method createResendCandidate, which can be extended, but its used only for tests. As I need custom logic in the resend candidate, but I want to reuse the rest of the functionality, it would be good if this method is used instead of the constructor directly.

        Attachments

          Activity

            People

            • Assignee:
              dkulp Daniel Kulp
              Reporter:
              gergand Gergan Dimitrov
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified