[CXF-6558] DefaultEncryptingOAuthDataProvider.getAccessToken throws SecurityException on invalid accessToken format

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.1.2
• Fix Version/s: 3.1.3, 3.0.7
• Component/s: JAX-RS Security
• Estimated Complexity: Unknown
• Assignee: Sergey Beryozkin
• Reporter: Karl von Randow
• Created: 25/Aug/15 21:33
• Updated: 14/Oct/16 14:12
• Resolved: 26/Aug/15 10:32

Description

The `DefaultEncryptingOAuthDataProvider.getAccessToken` method calls `ModelEncryptionSupport.decryptAccessToken` which throws a SecurityException if the input doesn't match they crypto algorithm's desired input. This results in a server error.

I suggest that this method should catch the SecurityException and instead throw an OAuthServiceException, as specified by the signature of `getAccessToken`.

e.g. `throw new OAuthServiceException(OAuthConstants.ACCESS_DENIED, e);`

This would enable invalid access tokens to be rejected cleanly back to the client. I am happy to provide a patch for this issue.