[CXF-6454] Orphaned JMS connections created in endless loop

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.0.5
• Fix Version/s: 3.1.14, 3.2.1
• Component/s: JMS, Transports
• Estimated Complexity: Unknown
• Assignee: Christian Schneider
• Reporter: Waldemar Szostak
• Created: 10/Jun/15 11:35
• Updated: 27/Oct/17 08:31
• Resolved: 15/Mar/17 14:31

Description

Problem description

In JMSFactory.createConnection(JMSConfiguration):

public static Connection createConnection(JMSConfiguration jmsConfig) throws JMSException {
	String username = jmsConfig.getUserName();
	ConnectionFactory cf = jmsConfig.getConnectionFactory();
	Connection connection = username != null 
		? cf.createConnection(username, jmsConfig.getPassword())
		: cf.createConnection();
	if (jmsConfig.getDurableSubscriptionClientId() != null) {
		connection.setClientID(jmsConfig.getDurableSubscriptionClientId());
	}
	return connection;
}

there is no exception handling if the clientID fails to be set. Such an exception would exit this method without passing the reference to the just-opened JMS connection to exception handling code (JMSDestination.createTargetDestinationListener()).

Moreover, JMSDestination.restartConnection() keeps on starting new connections (there is no max attempt restriction!) until it creates one without an exception thrown in the process.

Now, if the clientID is already connected to the ESB, this creation of new connection will last until server resources are no longer available to the JVM.

Possible solution

1. Close the connection if it's not possible to set the specified clientID at the time:

   public static Connection createConnection(JMSConfiguration jmsConfig) throws JMSException {
   	String username = jmsConfig.getUserName();
   	ConnectionFactory cf = jmsConfig.getConnectionFactory();
   	Connection connection = username != null 
   			? cf.createConnection(username, jmsConfig.getPassword()) 
   			: cf.createConnection();
   	if (jmsConfig.getDurableSubscriptionClientId() != null) {
   		try {					connection.setClientID(jmsConfig.getDurableSubscriptionClientId());
   		} catch (InvalidClientIDException e) {
   			connection.close();
   			throw e;
   		}
   	}
   	return connection;
   }

2. Add a setting to restrict the maximum attempts to restart the connection in JMSDestination.restartConnection() A configurable value would be best, but even a hardcoded.. anything but the practically endless loop

Issue Links

• links to: GitHub Pull Request #132