[CXF-6229] EndpointReferenceUtils.getSchema does NOT cache negative schema parsing

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.0.2
• Fix Version/s: 3.0.4, 2.7.15, 3.1
• Estimated Complexity: Unknown
• Assignee: Daniel Kulp
• Reporter: Krzysztof Kucap
• Created: 29/Jan/15 15:45
• Updated: 16/Feb/15 16:08
• Resolved: 09/Feb/15 20:44

Description

Although EndpointReferenceUtils.getSchema(ServiceInfo serviceInfo, Bus b) code pretend that it does not enter synchronized section if serviceInfo has Schema.class.getName() property that is null, the fact is that serviceInfo is not able to preserve null values because of serviceInfo.setProperty(String name, Object v) implementation which REMOVES property if passed value is null (EndpointReferenceUtils.createSchema(ServiceInfo serviceInfo, Bus b) calls serviceInfo.setProperty() with possible null value).

Such implementation in case of specifying wrong XSDs for service has a huge performance impact in multi-threading environment because every time EndpointReferenceUtils.getSchema() is called it enters synchronized section and tries to parse wrong XSDs.

So, EndpointReferenceUtils.getSchema() should stop pretend that it caches negative XSD parsing(s) or caching should be fixed.