Uploaded image for project: 'CXF'
  1. CXF
  2. CXF-6229

EndpointReferenceUtils.getSchema does NOT cache negative schema parsing

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 3.0.2
    • 3.0.4, 2.7.15, 3.1
    • None
    • None
    • Unknown

    Description

      Although EndpointReferenceUtils.getSchema(ServiceInfo serviceInfo, Bus b) code pretend that it does not enter synchronized section if serviceInfo has Schema.class.getName() property that is null, the fact is that serviceInfo is not able to preserve null values because of serviceInfo.setProperty(String name, Object v) implementation which REMOVES property if passed value is null (EndpointReferenceUtils.createSchema(ServiceInfo serviceInfo, Bus b) calls serviceInfo.setProperty() with possible null value).

      Such implementation in case of specifying wrong XSDs for service has a huge performance impact in multi-threading environment because every time EndpointReferenceUtils.getSchema() is called it enters synchronized section and tries to parse wrong XSDs.

      So, EndpointReferenceUtils.getSchema() should stop pretend that it caches negative XSD parsing(s) or caching should be fixed.

      Attachments

        Activity

          People

            dkulp Daniel Kulp
            a5phyx Krzysztof Kucap
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: