Uploaded image for project: 'CXF'
  1. CXF
  2. CXF-6101

Accept Header not Respected with Response from Custom MessageReader

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.0.2
    • 3.0.3, 3.1
    • JAX-RS
    • None
    • Unknown

    Description

      I have created a custom MessageBodyReader class which implements the readFrom method and attempts to deserialize a JSON message using a specialized deserializer. If this fails for some reason, I am throwing a WebApplicationException with a Response build like this:

      Response.status(HttpStatus.BAD_REQUEST_400).entity(myCustomResponseObject).build()

      On the incoming request there is an Accept header which is respected when processing proceeds normally, but this header is not respected if I throw an exception in the readFrom method (content type of the response is always "text/xml"). The problem seems to be in the JAXRSInInterceptor class which creates a default message which does not have the exchange set on it, so when the createMessage method is invoked it is unable to find the correct content type so it will always default to "text/xml". Contrast the way this method works with how the ServiceInvokerInterceptor class creates a new message, it sets the exchange on the new message first before creating it.

      I realize I could set an explicit media type when creating the response but this seems to defeat the purpose of server side content negotiation.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            sergey_beryozkin Sergey Beryozkin
            jjathman Joseph Athman
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment