[CXF-5995] ClientProxyImpl problem with handling @BeanParams with null headers/cookies.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0, 3.0.1
• Fix Version/s: 2.7.13, 3.0.2, 3.1
• Estimated Complexity: Unknown
• Assignee: Sergey Beryozkin
• Reporter: Michał P
• Created: 10/Sep/14 09:03
• Updated: 16/Feb/15 16:09
• Resolved: 10/Sep/14 10:40

Description

Problem occures when my @BeanParam object has String @HeaderParam values that are null.

On client side inside ClientProxyImpl#getValuesFromBeanParam always returns full Map<String, BeanPair> even when BeanPair has null values.

ClientProxyImpl.java

// line 481
String propertyName = m.getName().substring(3);
Method getter = bean.getClass().getMethod("get" + propertyName, new Class[]{});
// Object value is null
Object value = getter.invoke(bean, new Object[]{});
String annotationValue = AnnotationUtils.getAnnotationValue(annotation);
values.put(annotationValue, new BeanPair(value, m.getParameterAnnotations()[0]));

Methods such handleHeaders, handleCookies has useless condition that is
always true (BeanPair is never null)

ClientProxyImpl.java

// line 585
for (Map.Entry<String, BeanPair> entry : values.entrySet()) {
    if (entry.getValue() != null) {
        headers.add(entry.getKey(), convertParamValue(entry.getValue().getValue(), entry.getValue().getAnns()));
    }
}

That couses unintended behaviour on server side when server receives BeanParam objects with fields with String value equal to "null".

I've sent no headers but servers received header with "null" String.