[CXF-5895] asmhelper broken with asm 5

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.2
• Estimated Complexity: Unknown
• Assignee: Daniel Kulp
• Reporter: Romain Manni-Bucau
• Created: 21/Jul/14 18:15
• Updated: 16/Feb/15 16:08
• Resolved: 28/Jul/14 18:15

Description

asmhelper works only with asm itself but not shades cause of visitFrame.

org.apache.cxf.common.util.ASMHelper#tryClass needs to change getMethod call from

cls.getMethod("visitFrame", Integer.TYPE, String.class,
                              String.class, String.class);

to

cls.getMethod("visitFrame", Integer.TYPE, Integer.TYPE,
                              Object[].class,  Integer.TYPE, Object[].class);

see org.apache.cxf.common.util.ASMHelper.MethodVisitor#visitFrame

PS: xbean asm4 shade can then be removed since not compatible