[CXF-5629] In robust one-way fault the fault message is written twice

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0
• Fix Version/s: 2.7.11, 3.0
• Estimated Complexity: Unknown
• Assignee: Daniel Kulp
• Reporter: Grzegorz Grzybek
• Created: 20/Mar/14 12:33
• Updated: 11/Jul/14 12:50
• Resolved: 20/Mar/14 20:49

Description

I have robust one-way operation. However the resulting soap fault is not written to response, because the output stream is closed, as the same faultObserver is called twice:

1. in org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(Message):

boolean isOneWay = false;
if (message.getExchange() != null) {
    if (message.getContent(Exception.class) != null) {
        message.getExchange().put(Exception.class, ex2);
    }
    isOneWay = message.getExchange().isOneWay() 
        && !MessageUtils.isTrue(message.getContextualProperty(Message.ROBUST_ONEWAY));
}

if (faultObserver != null && !isOneWay) {
    faultObserver.onMessage(message);
}

2. later in org.apache.cxf.interceptor.OneWayProcessorInterceptor.handleMessage(Message):

if (message.getContent(Exception.class) != null) {
    // return the fault over the response fault channel
    MessageObserver faultObserver = chain.getFaultObserver();
    if (faultObserver != null) {
        message.getExchange().setOneWay(false);
        faultObserver.onMessage(message);
    } 
    return;
}

However, exchage is one-way only in second call, but the soap fault has no change to get to client (output stream is closed).

I'm working on a patch