[CXF-5095] Allow adding attachments to the contetx using jaxws attachments

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7.5
• Fix Version/s: 2.6.9, 2.7.6
• Component/s: JAX-WS Runtime
• Estimated Complexity: Unknown
• Assignee: Akitoshi Yoshida
• Reporter: Akitoshi Yoshida
• Created: 27/Jun/13 10:38
• Updated: 14/Aug/13 15:49
• Resolved: 12/Jul/13 08:11

Description

Currently, it is not possible to add attachments using jaxws's attachments.

http://cxf.547215.n5.nabble.com/Attachments-for-Dispatch-not-supported-td5729017.html

There are some options to get the wiring of attachments (of cxf and jaxws) working.

Option 1
change the WrappedMessageContext's put method so that the cxf's native attachments-set gets added when the jaxws attachments-map is added.
This is probably the simplest approach. But its limitation is that you cannot reflect any change of the original jaxws attachments-map into the actual cxf's attachments-set stored in the context, once this cxf's attachments-set is created and inserted.

Option 2
introduce package local WrappedAttachments that holds the original jaxws's attachments-map and expose it as the cxf's attachments-set. That means, when the jaxws's attachments-map is inserted, WrappedMessageContext can wrap it with WrappedAttachments which is treated as cxf's attachments-set. In this way, any operations on cxf's attachments-set or jaxws' attachments-map remain consistent.

Option 2 is more flexible than option 1 and prevents potential confusion. So, I think we can choose option 2.