[CXF-5094] wsdl2js generates invalid js names when wsdl contains hyphens

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.7.5
• Component/s: WS-* Components
• Labels: hyphen patch wsdl2js
• Estimated Complexity: Unknown
• Assignee: Unassigned
• Reporter: Florian Vielhauer
• Created: 26/Jun/13 15:12
• Updated: 26/Jun/13 15:13

Description

Invalid JS code is generated by wsdl2js if WSDL contains hyphens.

Reproduction:

 
wsdl2js.bat ExampleService.wsdl

generates invalid ExampleService.js:

//..
function X1_RequestParam () {
    this.typeMarker = 'X1_RequestParam';
    this._input-parameter = '';
}
//..

Resolution:

Please see attached patch.

The patch only fixes hyphens, which should be the most common problematic case. However, there are other characters and combinations which can also lead to invalid JS names! So it is probably a good idea to look at that in more detail to improve compatibility... at least for my WSDL the hyphen patch fixes the problems.