[CXF-5056] EndorsingSupportingTokens with both transport security and message layer security applied

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.2
• Fix Version/s: 2.6.9, 2.7.6
• Component/s: WS-* Components
• Labels: newbie
• Estimated Complexity: Moderate
• Assignee: Colm O hEigeartaigh
• Reporter: Chance BJ
• Created: 05/Jun/13 16:00
• Updated: 14/Aug/13 15:49
• Resolved: 14/Jun/13 15:53

Description

According to WS-SecurityPolicy, EndorsingSupportingTokens signs timestamp if using transport security, and sign main message signature if using message layer security.

In CXF WS-Security, if TLS is used (regardless of Transport policy applied or not), it always requires timestamp be signed, without checking if message layer security is configured and main message signature is endorsed.

AbstractSupportingTokenPolicyValidator.java

/**

• Check the endorsing supporting token policy. If we're using the Transport Binding then
• check that the Timestamp is signed. Otherwise, check that the signature is signed.
• @return true if the endorsed supporting token policy is correct
  */
  private boolean checkEndorsed(List<WSSecurityEngineResult> tokenResults)
  Unknown macro: { if (isTLSInUse()) { return checkTimestampIsSigned(tokenResults); } return checkSignatureIsSigned(tokenResults); }

Say we have a ws-security policy which requires main message signature be endorsed, timestamp itself is not signed by endorsing token, and transport policy is not applied/attached.
If we run the test case over plain HTTP, the test case passes.
If we run the test case over HTTPS, the test case fails.

This raises following questions:
1. If you have both transport security and message layer security, which one to check? or which one first? or both?
2. When enforcing EndorsingSupportingToken, does "Transport security" in EndorsingSupportingToken means "Transport Policy Applied" or "SSL applied regardless of Transport policy applied".

I just want to bring this up for discussion first. If we have a conclusion on how it should work, I will submit a patch.

Thanks

Issue Links

• is cloned by: CXF-5083 Failure in checkEndorsed() when timestamp is not signed with EndorsingSupportingTokens